search

code-423n4 / 2022-07-golom-findings

2 stars 1 forks source link

call() should be used instead of transfer() on an address payable. #436

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Lines of code

https://github.com/code-423n4/2022-07-golom/blob/e5efa8f9d6dda92a90b8b2c4902320acf0c26816/contracts/core/GolomTrader.sol#L154

Vulnerability details

Impact

The transfer() function is deprecated and it might fail in certain cases.

Proof of Concept

The use of the deprecated transfer() function for an address will inevitably make the transaction fail when:

  1. The claimer smart contract does not implement a payable function.
  2. The claimer smart contract does implement a payable fallback that uses more than 2300 gas unit.
  3. The claimer smart contract implements a payable fallback function that needs less than 2300 gas units but is called through proxy, raising the call's gas usage above 2300.

Additionally, using higher than 2300 gas might be mandatory for some multisig wallets.

Tools Used

Solidity Visual Developer of VSCode

Recommended Mitigation Steps

Recommend using call() instead of transfer().

KenzoAgada commented 2 years ago

Duplicate of #343