search

code-423n4 / 2022-07-swivel-findings

0 stars 1 forks source link

QA Report #108

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

1) Missing natspec comment.

  1. ZcToken.sol
    1. There is no natspec comment for parameter holder in withdraw function.
    2. There is no natspec comment for parameter holder in redeem function.

2) Declare magic numbers as constants in VaultTracker.sol

Magic number 1e26 used in 6 functions: addNotional, removeNotional, redeemInterest, transferNotionalFrom, transferNotionalFee and removeNotional.