search

code-423n4 / 2022-07-swivel-findings

0 stars 1 forks source link

QA Report #120

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

missing checks for approve return status

impact

Some tokens return bool status after the approve, if approve fails the token will return false and you should check this.

Instances of issues:

https://github.com/code-423n4/2022-07-swivel/blob/daf72892d8a8d6eaa43b9e7d1924ccb0e612ee3c/Swivel/Swivel.sol#L362

Recommendation for mitigation:

check the return status of token

JeeberC4 commented 2 years ago

Warden submitted multiple QA Reports. Will not be judged.