Open code423n4 opened 2 years ago
https://github.com/code-423n4/2022-07-swivel/blob/fd36ce96b46943026cb2dfcb76dfa3f884f51c18/Swivel/Swivel.sol#L33
State aaveAddr was call on constructor so it should be add immutable to initialize the state. it makes the state have a value and the cost are cheaper.
https://github.com/code-423n4/2022-07-swivel/blob/fd36ce96b46943026cb2dfcb76dfa3f884f51c18/VaultTracker/VaultTracker.sol#L248
natspect comment of param a was missing so give explanation about a to the comment natspec. it can increase readibility
https://github.com/code-423n4/2022-07-swivel/blob/fd36ce96b46943026cb2dfcb76dfa3f884f51c18/Creator/ZcToken.sol#L120
natspect comment of param holder was missing so give explanation about holder to the comment natspec. it can increase readibility
1 add immutable to AaveAddr
https://github.com/code-423n4/2022-07-swivel/blob/fd36ce96b46943026cb2dfcb76dfa3f884f51c18/Swivel/Swivel.sol#L33
State aaveAddr was call on constructor so it should be add immutable to initialize the state. it makes the state have a value and the cost are cheaper.
2 missing natspec comment parameter a
https://github.com/code-423n4/2022-07-swivel/blob/fd36ce96b46943026cb2dfcb76dfa3f884f51c18/VaultTracker/VaultTracker.sol#L248
natspect comment of param a was missing so give explanation about a to the comment natspec. it can increase readibility
3 Missing natspect comment parameter holder
https://github.com/code-423n4/2022-07-swivel/blob/fd36ce96b46943026cb2dfcb76dfa3f884f51c18/Creator/ZcToken.sol#L120
natspect comment of param holder was missing so give explanation about holder to the comment natspec. it can increase readibility