L-1 Divide before Multiply
Witch.sol L#594
Solidity is unable to handle floating point numbers and will therefore truncate integers during division.
This may be a different cut for auctioneerCut as the solution is different.
The multiplication should be always placed at the end to avoid miscalculations like the following one:
a = (b/d)*c
0 = (5/10)*2
a = (b * c)/ 2
1 = (5 * 2)/10
N-1 NATSPEC IS INCOMPLETE
Wit.ch.sol L#561
There'sa missing @return
N-2 EVENT IS MISSING INDEXED FIELDS
Each event should use three indexed fields if there are three or more fields
Witch.sol L#33Witch.sol L#43
alcueca
commented
2 years ago
L-1 Divide before Multiply Witch.sol L#594 Solidity is unable to handle floating point numbers and will therefore truncate integers during division. This may be a different cut for
auctioneerCutas the solution is different. The multiplication should be always placed at the end to avoid miscalculations like the following one:N-1 NATSPEC IS INCOMPLETE Wit.ch.sol L#561 There'sa missing
@returnN-2 EVENT IS MISSING
INDEXEDFIELDS Eacheventshould use threeindexedfields if there are three or more fields Witch.sol L#33 Witch.sol L#43