QA Report - Githubissues

code423n4 commented 2 years ago

use safeMint() instead of _mint() to make sure recipient is aware of receiving tokens and tokens are not locked in contract accounts:
- https://github.com/code-423n4/2022-08-foundation/blob/792e00df429b0df9ee5d909a0a5a6e72bd07cf79/contracts/NFTCollection.sol#L271
- https://github.com/code-423n4/2022-08-foundation/blob/792e00df429b0df9ee5d909a0a5a6e72bd07cf79/contracts/NFTDropCollection.sol#L182 . In this loop, just use safeMint() when i == firstTokenId and then use mint() is safe and gas saving because the only first external call fromsafeMint()'s logic is enough to check whether recipient is aware of receiving token

HardlyDifficult commented 2 years ago

Use safeMint

Agree will fix - for context see our response here.

HickupHH3 commented 2 years ago

dup of #183

code-423n4 / 2022-08-foundation-findings