code-423n4 / 2022-08-foundation-findings

0 stars 0 forks source link

QA Report #239

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

See the markdown file with the details of this report here.

HardlyDifficult commented 2 years ago

Use safeMint

Agree will fix - for context see our response here.

Inconsistent symbol check

Agree that we were inconsistent with these checks. We have moved the NFTDropCollection requirement into the factory so that both collection types are implemented in a similar fashion, and we went with the factory instead of the collection init in order to follow the best practice of fail fast.