search

code-423n4 / 2022-08-foundation-findings

0 stars 0 forks source link

QA Report #249

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

See the markdown file with the details of this report here.

HardlyDifficult commented 2 years ago

Minting does not work for ERC-1155 tokens

Agree, it may be possible to list a sale for an 1155 token but then minting would fail. We will be adding a 165 check for ERC721 on create sale.

Love that you included a POC for this as well!

Sales can be created even when sold out

Disagree this is a problem or can/should be addressed. As you noted we do check if the collection has been sold out already. Yes contracts can lie about this but then any other solution, like what you recommend, is subject to the same problem. In the end there's nothing we can do to stop malicious contracts if we want to remain an open/flexible protocol.

Use of _mint can result in NFT loss

Agree will fix - for context see our response here.

Overflow can happen in versionNFTCollection++

Agree although this is very unlikely and an admin-only function. However we have switched to using checked math here since optimizing for admin-only calls was never meant to be a goal anyways.