search

code-423n4 / 2022-08-foundation-findings

0 stars 0 forks source link

QA Report #289

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

HardlyDifficult commented 1 year ago

[L-01] PROTOCOL AND BUY REFERRER FEES CAN BE 0 WHEN CALLING createFixedPriceSale

This is working as intended. 1% of 0 is 0.. It is fair to say that our documentation could be more clear about how this would work.

[L-02] _symbol INPUT CAN BE CHECKED

Agree that we were inconsistent with these checks. We have moved the NFTDropCollection requirement into the factory so that both collection types are implemented in a similar fashion, and we went with the factory instead of the collection init in order to follow the best practice of fail fast.

[L-03] UNRESOLVED TODO COMMENT

Agree, will fix.

[N-01] REDUNDANT NAMED RETURNS

Agree, we have opted to use the named returns instead of return ... This is more consistent with other code in our repo and saves a bit of on the contract size. We also like named returns as a way of improving natspec, and typechain (particularly when a tuple is returned).

[N-02] UNUSED IMPORTS

Agree, will fix.

[N-03] MISSING NATSPEC COMMENTS

Fair feedback -- for natspec we aim for complete coverage of the public interfaces but for internal/private/libraries we have some gaps in order to reduce redundancy, for those we aim to include comments where things are unclear or not obvious from the function and variable names.