search

code-423n4 / 2022-08-olympus-findings

5 stars 4 forks source link

QA Report #475

Closed code423n4 closed 1 year ago

code423n4 commented 2 years ago

1.

Initializing the variable in the following for loops is unnecessary as they get set to 0 by default

Contract: Kernel.sol

line 397

Contract: KernelUtils.sol

line 43
    line 58

Recommendation:

for (uint256 i; i < reqLength; )

for (uint256 i; i < 5; ) {
for (uint256 i; i < 32; ) {

This will also provide consistency across all contracts given that all other for loops are coded as such.

0xLienid commented 2 years ago

should be gas optimization rather than QA

0xean commented 1 year ago

closing as invalid, low quality report.