code-423n4 / 2022-09-artgobblers-findings

0 stars 0 forks source link

QA Report #364

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

low-critical

There is no check for null in constructor

https://github.com/code-423n4/2022-09-artgobblers/blob/main/src/Goo.sol#L82-L85 https://github.com/code-423n4/2022-09-artgobblers/blob/main/src/Pages.sol#L177-L183 https://github.com/code-423n4/2022-09-artgobblers/blob/main/src/ArtGobblers.sol#L311-L327

Need to null check for mistake.

GalloDaSballo commented 1 year ago

1L

GalloDaSballo commented 1 year ago

Would close with new rules, the fact that you call it null leads me to believe you don't code