code-423n4 / 2022-09-artgobblers-findings

0 stars 0 forks source link

QA Report #467

Closed code423n4 closed 1 year ago

code423n4 commented 2 years ago

Low

1. A floating pragma is set

Description

Contracts have the pragma solidity directive ^0.8.0. It is recommended to specify a fixed compiler version to ensure that the bytecode produced does not vary between builds. This is especially important if you rely on bytecode-level verification of the code.

Mitigation

Lock the pragma.

Lines in the code

ArtGobblers.sol#L2 Goo.sol#L2 Pages.sol#L2 GobblersERC1155B.sol#L2 GobblersERC721.sol#L2 PagesERC721.sol#L2 ChainlinkV1RandProvider.sol#L2 GobblerReserve.sol#L2 DeployBase.s.sol#L2 DeployRinkeby.s.sol#L2 LogisticToLinearVRGDA.sol#L2 LogisticVRGDA.sol#L2 VRGDA.sol#L2 LinearVRGDA.sol#L2 LibGOO.sol#L2 FixedPointMathLib.sol#L2 ERC721.sol#L2 SignedWadMath.sol#L2 MerkleProofLib.sol#L2 LibString.sol#L2 Owned.sol#L2

2. Outdated compiler version

Description

It's a best practice to use the latest compiler version. The specified minimum compiler version is quite old (0.8.0). Older compilers might be susceptible to some bugs. It's recommended changing the solidity version pragma to the latest version to enforce the use of an up-to-date compiler.

A list of known compiler bugs and their severity can be found here: https://etherscan.io/solcbuginfo

To check the bugfixed and improvements of latest versions see the following link

Mitigation

Update the pragma to 0.8.17

Lines in the code

ArtGobblers.sol#L2 Goo.sol#L2 Pages.sol#L2 GobblersERC1155B.sol#L2 GobblersERC721.sol#L2 PagesERC721.sol#L2 ChainlinkV1RandProvider.sol#L2 GobblerReserve.sol#L2 DeployBase.s.sol#L2 DeployRinkeby.s.sol#L2 LogisticToLinearVRGDA.sol#L2 LogisticVRGDA.sol#L2 VRGDA.sol#L2 LinearVRGDA.sol#L2 LibGOO.sol#L2 FixedPointMathLib.sol#L2 ERC721.sol#L2 SignedWadMath.sol#L2 MerkleProofLib.sol#L2 LibString.sol#L2 Owned.sol#L2

GalloDaSballo commented 2 years ago

1NC

GalloDaSballo commented 2 years ago

Would close with new rules, this is not a good report