search

code-423n4 / 2022-09-artgobblers-findings

0 stars 0 forks source link

Upgraded Q -> M from 211 [1665775603120] #484

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

Judge has assessed an item in Issue #211 as Medium risk. The relevant finding follows:

GalloDaSballo commented 1 year ago

[2] Gobbler accounting can be wrong

At ArtGobblers.sol#L458 a 1 is added to gobblersOwned to factor in the legendary, but then _mint() adds 1 again, meaning that the variable gobblersOwnedis off by 1 per legendary gobbler minted. This is not exploitable, but could lead to problems in external projects that use balanceOf to get an address gobblers balance.

Dup of https://github.com/code-423n4/2022-09-artgobblers-findings/issues/333