code-423n4 / 2022-09-nouns-builder-findings

10 stars 6 forks source link

QA Report #220

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

Consider emitting an event after tokens are safely transferred to the rightful owner after an auction has been completed. This will allow for off chain monitoring in addition to allowing users to observe and trust that these changes have occurred correctly.

Source: https://github.com/code-423n4/2022-09-nouns-builder/blob/main/src/auction/Auction.sol#L344-L365

GalloDaSballo commented 2 years ago

NC