search

code-423n4 / 2022-09-nouns-builder-findings

10 stars 6 forks source link

QA Report #663

Open code423n4 opened 2 years ago

code423n4 commented 2 years ago

  1. Missing zero address check he following functions are missing zero address checks which may require redeployment of contracts Manager.constructor() Auction._authorizeUpgrade()

  2. Missing zero value check The following functions are missing zero value checks. Setting the state variable to 0 would affect other functions in the contract, possibly causing reverts.

Auction.setDuration() Auction.setReservePrice() Auction.setTimeBuffer() Auction.setMinimumBidIncrement()

GalloDaSballo commented 2 years ago

1L for zero-check on adress