search

code-423n4 / 2022-09-nouns-builder-findings

10 stars 6 forks source link

QA Report #720

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

[N 01] Not checking address(0) for vetoer. https://github.com/code-423n4/2022-09-nouns-builder/blob/7e9fddbbacdd7d7812e912a369cfd862ee67dc03/src/governance/governor/Governor.sol#L71

[N 02] Vetoer can veto canceled proposals, expired proposals .. etc. Checking if the proposal has succeeded has not a real impact so why check if it has succeeded and not check if it was canceled? Check both or check none.

https://github.com/code-423n4/2022-09-nouns-builder/blob/7e9fddbbacdd7d7812e912a369cfd862ee67dc03/src/governance/governor/Governor.sol#L390

[N 03] It is possible to cancel and already canceled proposal https://github.com/code-423n4/2022-09-nouns-builder/blob/7e9fddbbacdd7d7812e912a369cfd862ee67dc03/src/governance/treasury/Treasury.sol#L180

[N 04] totalFounderOwnership() in Token.sol can return wrong % of ownership if founders vesting expired.

https://github.com/code-423n4/2022-09-nouns-builder/blob/7e9fddbbacdd7d7812e912a369cfd862ee67dc03/src/token/Token.sol#L240

GalloDaSballo commented 1 year ago

1L 3NC

I wish the warden wrote more in detail, prob I could have raised some of these