search

code-423n4 / 2022-09-nouns-builder-findings

10 stars 6 forks source link

Upgraded Q -> M from 593 [1664289691118] #730

Closed code423n4 closed 2 years ago

code423n4 commented 2 years ago

Judge has assessed an item in Issue #593 as Medium risk. The relevant finding follows:

GalloDaSballo commented 2 years ago

Issue 2 founderPct may be larger than 100 Due to inconsistently casting founderPct to uint(8), founderPct may be truncated and pass all verification checks however when the baseTokenIDs is assigned, the function through loops through the full value which can cause the founder to receive full ownership of all NFTs even if OwnershipPct is set to 0.

Consider adding a check to make sure that founderPct < type(uint8).max

Dup of #303