code-423n4 / 2022-09-party-findings

2 stars 0 forks source link

Fee = 0 in case supply is less then 10 #224

Closed code423n4 closed 1 year ago

code423n4 commented 2 years ago

Lines of code

https://github.com/PartyDAO/party-contracts-c4/blob/3896577b8f0fa16cba129dc2867aba786b730c1b/contracts/distribution/TokenDistributor.sol#L352

Vulnerability details

In case supply is less then 10 fee will be always = 0, (which is almost impossible with ETH but it's not 100% excludible with an ERC20 token in case it's value is very high and precision is low) . A check that supply shall more then 10 shall be set.

merklejerk commented 1 year ago

Duplicate of #265