search

code-423n4 / 2022-09-party-findings

2 stars 0 forks source link

Unsafe ERC721 operations #251

Closed code423n4 closed 1 year ago

code423n4 commented 2 years ago

Lines of code

https://github.com/PartyDAO/party-contracts-c4/blob/3896577b8f0fa16cba129dc2867aba786b730c1b/contracts/crowdfund/Crowdfund.sol#L301

Vulnerability details

Impact

It is recommended to use safeTransfer and safeTransferFrom when transferring ERC721 and ERC20 token

Tools Used

Manual audit

Recommended Mitigation Steps

Use the safeTransfer and safeTransferFrom functions to transfer ERC721 and ERC20 tokens

merklejerk commented 1 year ago

Duplicate of #20

HardlyDifficult commented 1 year ago

The rec for this line is invalid.