code-423n4 / 2022-09-party-findings

2 stars 0 forks source link

Rounding errors can lead to wrong voting power #255

Closed code423n4 closed 1 year ago

code423n4 commented 2 years ago

Lines of code

https://github.com/PartyDAO/party-contracts-c4/blob/3896577b8f0fa16cba129dc2867aba786b730c1b/contracts/crowdfund/Crowdfund.sol#L370-L375

Vulnerability details

Impact

The calculation of voting power in Crowdfund._getFinalContribution() can lead to loss of voting power due to rounding errors.

Tools Used

Manual audit

merklejerk commented 1 year ago

Duplicate of #114