search

code-423n4 / 2022-09-party-findings

2 stars 0 forks source link

multiply users can `contribution` with one `Token` #289

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

Lines of code

https://github.com/PartyDAO/party-contracts-c4/blob/main/contracts/crowdfund/Crowdfund.sol#L393 https://github.com/PartyDAO/party-contracts-c4/blob/main/contracts/gatekeepers/TokenGateKeeper.sol#L31-L38

Vulnerability details

Impact

Users, don't have a Token for contribution but they can bypass this check easy

Proof of Concept

If the Crowdfund is private by using TokenGateKeeper.sol The contributor can contribution and then send the NFT or ERC20 to another user address. So two users or more can send a contribution with the same Token TO BYPASS isAllowed()

Recommended Mitigation Steps

If it uses NFT you can track the ids

merklejerk commented 1 year ago

Gatekeepers are out of scope and no assets would be at risk. However, this particular gatekeeper TokenGateKeeper is intended for casual use so we aren't concerned.

HardlyDifficult commented 1 year ago

Out of scope - closing as invalid.