Closed code423n4 closed 1 year ago
src/escrows/INVEscrow.sol: L44
src/Fed.sol: L48 L57 L75
src/Market.sol: L149 L161 L183 L194 L212
src/DBR.sol: L53 L62
src/escrows/GovTokenEscrow.sol: L30
src/escrows/SimpleERC20Escrow.sol: L25
indexed
src/DBR.sol: L381 L382
src/Market.sol: L616 L617 L619
external
public
src/escrows/GovTokenEscrow.sol: L30 L43 L52
src/Market.sol: L161 L172 L183 L194 L212 L559 L575 L578 L591
src/escrows/INVEscrow.sol: L44 L59 L79
src/Oracle.sol: L66
src/Fed.sol: L48 L57 L66 L75 L131
src/escrows/SimpleERC20Escrow.sol: L25 L36 L45
src/DBR.sol: L53 L81 L90 L99 L146 L158 L188 L215 L258 L300 L325
src/BorrowController.sol: L46
src/escrows/INVEscrow.sol: L2
src/escrows/SimpleERC20Escrow.sol: L2
src/Fed.sol: L2
src/BorrowController.sol: L2
src/Oracle.sol: L2
src/Market.sol: L2
src/escrows/GovTokenEscrow.sol: L2
src/DBR.sol: L2
0xean marked the issue as grade-c
1. Events not emmited
src/escrows/INVEscrow.sol: L44
src/Fed.sol: L48 L57 L75
src/Market.sol: L149 L161 L183 L194 L212
src/DBR.sol: L53 L62
src/escrows/GovTokenEscrow.sol: L30
src/escrows/SimpleERC20Escrow.sol: L25
2. Event is missing
indexed
fieldssrc/DBR.sol: L381 L382
src/Market.sol: L616 L617 L619
3. Use
external
instead ofpublic
for the following functionssrc/escrows/GovTokenEscrow.sol: L30 L43 L52
src/Market.sol: L161 L172 L183 L194 L212 L559 L575 L578 L591
src/escrows/INVEscrow.sol: L44 L59 L79
src/Oracle.sol: L66
src/Fed.sol: L48 L57 L66 L75 L131
src/escrows/SimpleERC20Escrow.sol: L25 L36 L45
src/DBR.sol: L53 L81 L90 L99 L146 L158 L188 L215 L258 L300 L325
src/BorrowController.sol: L46
4. Only libraries, abstract contracts and interfaces should use multiple compiler versions
src/escrows/INVEscrow.sol: L2
src/escrows/SimpleERC20Escrow.sol: L2
src/Fed.sol: L2
src/BorrowController.sol: L2
src/Oracle.sol: L2
src/Market.sol: L2
src/escrows/GovTokenEscrow.sol: L2
src/DBR.sol: L2