c4-judge
commented
1 year ago Picodes marked the issue as grade-b
Open code423n4 opened 1 year ago
c4-judge
commented
1 year ago Picodes marked the issue as grade-b
Report
Non-Critical Issues
[N-01]: Function defines a named return variable but then it uses return statements
Context:
return store.votingUnitsOf(address(this), _account);L39return _launchFundingCyclesFor(_projectId, _launchFundingCyclesData);L134return _reconfigureFundingCyclesOf(_projectId, _reconfigureFundingCyclesData);L177return store.balanceOf(address(this), _owner);L124Recommendation:
Choose named return variable or return statement. It is unnecessary to use both.
[N-02]: Wrong order of functions
Context:
Description:
According official solidity documentation functions should be grouped according to their visibility and ordered:
constructor
receive function (if exists)
fallback function (if exists)
external
public
internal
private
Recommendation:
Put the functions in the correct order according to the documentation.
[N-03]: NatSpec is missing
[N-04]: Public function can be external
Context:
Description:
Public functions can be declared external if they are not called by the contract.
Recommendation:
Declare these functions as external instead of public.
[N-05]: Typos
Context:
@param _tokenId The id of the token for which voting units are being transfered.L48 (change transfered to transferred)JBOperatable: Several functions in this contract can only be accessed by a project owner, or an address that has been preconfifigured to be an operator of the project.L19 (change preconfifigured to preconfigured)The contract responsibile for deploying the delegate.L34 (change responsibile to responsible)@param _blockNumber the blocknumber to check the voting power atL100 (change blocknumber to block number)@param _tierId The ID of the tier for which voting units are being transfered.L209 (change transfered to transferred)@param _tierId The ID of the tier for which voting units are being transfered.L239 (change transfered to transferred)@param _tierId The ID of the tier for which voting units are being transfered.L269 (change transfered to transferred)@return balance The number of tokens owners by the owner accross all tiers.L121 (change accross to across)@param _interfaceId The ID of the interface to check for adherance to.L173 (change adherance to adherence)Sets the beneificiary of the reserved tokens for tiers where a specific beneficiary isn't set.L363 (change beneificiary to beneficiary)@param _beneficiary The default beneificiary of the reserved tokens.L368 (change beneificiary to beneficiary)// Keep a reference to the flag indicating if the transaction should revert if all provded funds aren't spent.L545 (change provded to provided)User the hook to register the first owner if it's not yet regitered.L717 (change regitered to registered)@param _tokenId The ID of the token being transfered.L721 (change transfered to transferred)// Transfered must not be paused when not minting or burning.L728 (change Transfered to Transferred)@param _tokenId The ID of the token being transfered.L757 (change transfered to transferred)@param _tokenId The ID of the token for which voting units are being transfered.L782 (change transfered to transferred)// Keep a referecen to the tier being iterated on.L230 (change referecen to reference)@return balance The number of tokens owners by the owner accross all tiers.L497 (change accross to across)@return The reserved token benficiary.L597 (change benficiary to beneficiary)// Keep a reference to the idex to iterate on next.L719 (change idex to index)@param _beneficiary The reservd token beneficiary.L852 (change reservd to reserved)@param _tierId The ID the tier being transferedL862 (change transfered to transferred)// Forward the recieved weight and memo, and use this contract as a pay delegate.L88 (change recieved to received)@param _interfaceId The ID of the interface to check for adherance to.L176 (change adherance to adherence)