QA Report - Githubissues

1. typo in comments

superceeds --> supersedes

JBTiered721DelegateStore.sol#L176

referecen --> reference

JBTiered721DelegateStore.sol#L230

Initialise --> Initialize (this is repeated in many places, because there is function Initialize being used in other places better to keep it american and use this version)

accross --> across

benficiary --> beneficiary

reservd --> reserved

JBTiered721DelegateStore.sol#L852

transfered --> transferred

preconfifigured --> preconfigured

JBTiered721DelegateProjectDeployer.sol#L19

adherance --> adherence

provded --> provided

JBTiered721Delegate.sol#L545

regitered --> registered

JBTiered721Delegate.sol#L717

2. use of floating pragma

Contracts should be deployed with the same compiler version and flags that they have been tested with thoroughly. Locking the pragma helps to ensure that contracts do not accidentally get deployed using, for example, an outdated compiler version that might introduce bugs that affect the contract system negatively.

3. require()/revert() statements should have descriptive reason strings or custom error

4. _safemint() should be used rather than _mint() wherever possible

5. lines are too long

Usually lines in source code are limited to 80 characters. Its advised to keep lines lower than 120 characters. Today’s screens are much larger so it’s reasonable to stretch this in some cases. Since the files will most likely reside in GitHub, and GitHub starts using a scroll bar in all cases when the length is over 164 characters, the lines below should be split when they reach that length

code-423n4 / 2022-10-juicebox-findings

QA Report #151

1. typo in comments

2. use of floating pragma

3. require()/revert() statements should have descriptive reason strings or custom error

4. _safemint() should be used rather than _mint() wherever possible

5. lines are too long