code-423n4 / 2022-10-juicebox-findings

2 stars 0 forks source link

QA Report #217

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

Typos in comments

an hash -> a hash an hex -> a hex recieved -> received adherance -> adherence a tokens are -> tokens are transfered -> transferred transfered -> transferred transfered -> transferred transfered -> transferred transfered -> transferred accross -> across adherance -> adherence Initialize the sub class. -> Initialize the superclass. to mint reserved for -> to mint reserves for beneificiary -> beneficiary beneificiary -> beneficiary provded -> provided a tokens are -> tokens are regitered -> registered transfered -> transferred Transfered -> Transferred transfered -> transferred transfered -> transferred preconfifigured -> preconfigured responsibile -> responsible superceeds -> supersedes](https://github.com/jbx-protocol/juice-nft-rewards/blob/f9893b1497098241dd3a664956d8016ff0d0efd0/contracts/JBTiered721DelegateStore.sol#L176) referecen -> reference accross -> across benficiary -> beneficiary reservd -> reserved transfered -> transferred

Inconsistent use of British vs. American spelling in comments

American: un-initializable re-initialization Initialize initializer Initialize Initialize Initialize Initialize

British: initialise Initialise Initialise Initialise Initialise Initialise initialise Licence

drgorillamd commented 1 year ago

@mejango

c4-judge commented 1 year ago

Picodes marked the issue as grade-b