search

code-423n4 / 2022-10-thegraph-findings

0 stars 0 forks source link

QA Report #193

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

no need to compare callhookWhitelist[msg.sender] with true, just use callhookWhitelist[msg.sender] is enough.

https://github.com/code-423n4/2022-10-thegraph/blob/309a188f7215fa42c745b136357702400f91b4ff/contracts/gateway/L1GraphTokenGateway.sol#L214

pcarranzav commented 1 year ago

I much prefer being explicit, even if it's unnecessary - especially since it's the right part of an || statement