search

code-423n4 / 2022-10-thegraph-findings

0 stars 0 forks source link

Gas Optimizations #204

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago
  1. Instead of using && in a require, using double require can save gas In the following line: https://github.com/code-423n4/2022-10-thegraph/blob/main/contracts/governance/Governed.sol#L55 the require statement requires two conditions to be met. Instead of having just one require, two save gas one could have two requires one for each condition.

Mitigation: require(pendingGovernor != address(0), "pending governor address 0") require(msg.sender == pendingGovernor, "Caller must be pending governor");

similarly change could be made for the following: https://github.com/code-423n4/2022-10-thegraph/blob/main/contracts/upgrades/GraphProxy.sol#L142

  1. Use != 0 instead of > 0 to save gas Since there is no concept of negative in EVM, one could save gas by replacing <var> > 0 by <var> != 0

Instance: https://github.com/code-423n4/2022-10-thegraph/blob/main/contracts/gateway/L1GraphTokenGateway.sol#L217