code-423n4 / 2022-10-thegraph-findings

0 stars 0 forks source link

QA Report #216

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

1 - Check zero address implementation before the "acceptUpgrade" function.

It would worth to check the zero address implementation before the acceptUpgrade function, so the acceptUpgrade function would already have a non-zero implementation.

The zero address check could be in the updgradeTo function and that function could be used in the constructor, so the constructor also can check the non-zero implementation.

Links: