L-01: Setting implementation uses a 2 step procedure but setting of admin does not.
This is counterintuitive as the change of admin is of a higher importance than change of implementation. In the case of a user error, where a wrong address is set when changing implementation, it can always be fixed by calling the function again. However, change of admin has the ifAdmin modifier, and changing it to a wrong address is significantly more dangerous.
In my opinion, use of 2 step procedure is optional for change of implementation, whereas it should be used for change of admin as it an important role.
L-01: Setting implementation uses a 2 step procedure but setting of admin does not.
This is counterintuitive as the change of admin is of a higher importance than change of implementation. In the case of a user error, where a wrong address is set when changing implementation, it can always be fixed by calling the function again. However, change of admin has the
ifAdmin
modifier, and changing it to a wrong address is significantly more dangerous.GraphProxyStorage.sol#L130
Mitigation:
In my opinion, use of 2 step procedure is optional for change of implementation, whereas it should be used for change of admin as it an important role.