search

code-423n4 / 2022-10-traderjoe-findings

2 stars 0 forks source link

Upgraded Q -> M from #446 [1668468223347] #515

Closed c4-judge closed 1 year ago

c4-judge commented 1 year ago

Judge has assessed an item in Issue #446 as M risk. The relevant finding follows:

[L-01] There should be an upper limit for LBFactory.flashLoanFee https://github.com/code-423n4/2022-10-traderjoe/blob/79f25d48b907f9d0379dd803fc2abc9c5f57db93/src/LBFactory.sol#L66 https://github.com/code-423n4/2022-10-traderjoe/blob/79f25d48b907f9d0379dd803fc2abc9c5f57db93/src/LBFactory.sol#L474 If the admin sets the flashLoanFee too high, the flash loan functionality might be useless as users won't use it.

c4-judge commented 1 year ago

GalloDaSballo marked the issue as duplicate of #139

Simon-Busch commented 1 year ago

Marked this issue as Satisfactory as requested by @GalloDaSballo