search

code-423n4 / 2022-10-zksync-findings

3 stars 0 forks source link

QA Report #246

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

1. Floating Pragma

Description: Contracts should be deployed with the same compiler version and flags that they have been tested with thoroughly. Locking the pragma helps to ensure that contracts do not accidentally get deployed using, for example, an outdated compiler version that might introduce bugs that affect the contract system negatively.

Remediation: Lock the pragma version and also consider known bugs (https://github.com/ethereum/solidity/releases) for the compiler version that is chosen.

Pragma statements can be allowed to float when a contract is intended for consumption by other developers, as in the case with contracts in a library or EthPM package. Otherwise, the developer would need to manually update the pragma in order to compile locally.

c4-judge commented 1 year ago

GalloDaSballo marked the issue as grade-c