search

code-423n4 / 2022-10-zksync-findings

3 stars 0 forks source link

QA Report #364

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

This QA regards the following file hardhat.config.ts, found in this path: 2022-10-zksync/ethereum/hardhat.config.ts

Hardhat.config.ts states in line 22- 23:

  solidity: {
        version: '0.8.17’,

Here we see that the whole projects codebase is complied by solc version 0.8.17. This is the latest version of solidity. While it benefits the project at this stage to use this version for testing and debugging. The poupular argument of the newest version having bugs, has affected previous version as well.

Check out this thread for further explanation:

ethereum.stackexchange (last checked 09.11.2022)

Since this project uses the framework Hardhat, which at this date supports solidity 0.8.x up to 0.8.16, using the unsupported version may lead to «… Solidity stack stop working are incorrect or incomplete. It could also mean that console.log stops working.»

hardhat (last checked 09.11.2022)

For these stated reasons I recommend that the Zksync dev team use solc version 0.8.16 in hardhat.config.ts

c4-judge commented 1 year ago

GalloDaSballo marked the issue as grade-c