Upgraded Q -> M from #229 [1674661441196]

[c4-judge]

Judge has assessed an item in Issue #229 as M risk. The relevant finding follows:

Support for IERC165 interface id is missed Contract: https://github.com/code-423n4/2022-11-paraspace/blob/main/paraspace-core/contracts/protocol/tokenization/base/MintableIncentivizedERC721.sol#L572

Impact: Contract fails to support a valid interface which could lead to failure of genuine calls

Steps:

Observe the supportsInterface function supportsInterface(bytes4 interfaceId) external view virtual override(IERC165) returns (bool) { return interfaceId == type(IERC721Enumerable).interfaceId || interfaceId == type(IERC721Metadata).interfaceId; } Observe that support for IERC165 interface id is missing Recommendation: Kindly revise the function as below:

function supportsInterface(bytes4 interfaceId) external view virtual override(IERC165) returns (bool) { return interfaceId == type(IERC721Enumerable).interfaceId || interfaceId == type(IERC721Metadata).interfaceId || interfaceId == type(IERC165).interfaceId; }

[c4-judge]

dmvt marked the issue as duplicate of #52

[c4-judge]

dmvt marked the issue as satisfactory