code-423n4 / 2022-11-paraspace-findings

7 stars 4 forks source link

Upgraded Q -> M from #404 [1674736594739] #520

Closed c4-judge closed 1 year ago

c4-judge commented 1 year ago

Judge has assessed an item in Issue #404 as M risk. The relevant finding follows:

[L‑04] latestAnswer() is deprecated Use latestRoundData() instead so that you can tell whether the answer is stale or not. The latestAnswer() function returns zero if it is unable to fetch data, which may be the case if ChainLink stops supporting this API. The API and its deprecation message no longer even appear on the ChainLink website, so it is dangerous to continue using it.

There is 1 instance of this issue:

File: paraspace-core/contracts/misc/ParaSpaceOracle.sol

128: price = uint256(source.latestAnswer()); https://github.com/code-423n4/2022-11-paraspace/blob/c6820a279c64a299a783955749fdc977de8f0449/paraspace-core/contracts/misc/ParaSpaceOracle.sol#L128

c4-judge commented 1 year ago

dmvt marked the issue as duplicate of #5

c4-judge commented 1 year ago

dmvt marked the issue as partial-50