search

code-423n4 / 2022-12-Stealth-Project-findings

0 stars 0 forks source link

Gas Optimizations #21

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

kirk-baird commented 1 year ago

A nicely written report :+1:

I'm going to note issue 2) and 3) can be found in the public report and are considered not in scope.

c4-judge commented 1 year ago

kirk-baird marked the issue as grade-b

0x1f8b commented 1 year ago

A nicely written report 👍

I'm going to note issue 2) and 3) can be found in the public report and are considered in scope.

I added a note in 2 and 3 because these two specific entries was not found in the "known issues".

kirk-baird commented 1 year ago

The specific case mentioned in 2) does mutate params.amountIn here.

Therefore if calldata is used it will need to be copied to memory before being modified and there will be increased gas costs.