code-423n4 / 2022-12-escher-findings

0 stars 0 forks source link

overflow in buy function #545

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

Lines of code

https://github.com/code-423n4/2022-12-escher/blob/5d8be6aa0e8634fdb2f328b99076b0d05fefab73/src/minters/FixedPrice.sol#L57

Vulnerability details

Impact

the function doesn't check if the input is more the supply

Proof of Concept

the function doesn't have any condition check of amount

Tools Used

manually

Recommended Mitigation Steps

check the input for maximum or requirement for max supply

c4-judge commented 1 year ago

berndartmueller marked the issue as unsatisfactory: Insufficient quality