QA Report

[code423n4]

See the markdown file with the details of this report here.

[GalloDaSballo]

1) Unused error messages: NC

2) Allowed tokens are not easily inspectable by users NC

3) Usage of += / -= for cleaner code Disagree due to gas

4) Unused function `transferAvax`` R

5) Checks-effects-interaction pattern not respected L

6) Non-zero validation for withdrawToken L

7) Byte storage, int storage as well as the assigned setters are unused Disputing, they are used

8) Non-zero validation missing for setGuardian NC as it cannot be accepted

9) Unused import MinipoolManager NC

10) Sub-optimal design for token inflation L

11) Multisig reward distribution rounds down L

12) Unused import: TokenGGP NC

13) Missing non-zero validation for setOneInch L

14) Users can not easily inspect the list of added Defenders NC

15) avaxHalfRewards is rounded down 50% of the time you lose 1 wei Disputed as there's subtraction to deal with dust later

5L 1R R 6NC

[GalloDaSballo]

3L from dups

8L 1R 6NC

[c4-judge]

GalloDaSballo marked the issue as grade-a