search

code-423n4 / 2022-12-gogopool-findings

1 stars 0 forks source link

Upgraded Q -> 3 from #867 [1675460716325] #900

Closed c4-judge closed 1 year ago

c4-judge commented 1 year ago

Judge has assessed an item in Issue #867 as 3 risk. The relevant finding follows:

L-02, MinipoolManager, lines 670 - 684: The slash function slashes a node operator for the amount of whole duration. Since the cycles are in 14 days and the slashing is checked in the recordStakingEnd, if an operator has a duration of for example 180 days, but fail to gin rewards for one cycle, she will be slashed for the amount of whole duration and that would not be fair not fair.

c4-judge commented 1 year ago

GalloDaSballo marked the issue as duplicate of #493

c4-judge commented 1 year ago

GalloDaSballo marked the issue as satisfactory