search

code-423n4 / 2022-12-prepo-findings

0 stars 1 forks source link

Upgraded Q -> M from #201 [1671458492331] #339

Closed c4-judge closed 1 year ago

c4-judge commented 1 year ago

Judge has assessed an item in Issue #201 as M risk. The relevant finding follows:

Deposit function is not compatible with deflationary token The actual deposited amount might be lower than the specified depositAmount of the function parameter. This would lead to wrong interest rate calculations on the principal. Recommend transferring the tokens first and comparing pre-/after token balances to compute the actual deposited amount.

https://github.com/prepo-io/prepo-monorepo/blob/feat/2022-12-prepo/apps/smart-contracts/core/contracts/Collateral.sol#L45-L61

c4-judge commented 1 year ago

Picodes marked the issue as duplicate of #332

c4-judge commented 1 year ago

Picodes marked the issue as satisfactory