code-423n4 / 2022-12-tigris-findings

8 stars 4 forks source link

CWE-1164: Irrelevant Code #140

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

Lines of code

https://github.com/code-423n4/2022-12-tigris/blob/588c84b7bb354d20cbca6034544c4faa46e6a80e/contracts/Trading.sol#L321

Vulnerability details

Impact

Override statement missing from function.

Proof of Concept

function initiateLimitOrder( TradeInfo calldata _tradeInfo, uint256 _orderType, // 1 limit, 2 stop uint256 _price, ERC20PermitData calldata _permitData, address _trader ) external override {

Tools Used

Remix IDE

Recommended Mitigation Steps

Add override clause

code423n4 commented 1 year ago

Withdrawn by debo