code-423n4 / 2022-12-tigris-findings

8 stars 4 forks source link

QA Report #535

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

GalloDaSballo commented 1 year ago

L-01 Avoid performing multiplications after division in Solidity, as this can lead to a loss of precision L

L-02 Trading.setBlockDelay does not enforce the block delay requirements L

L-03 Possible DOS in BondNFT.distribute L

L-04 _bridgeMint access control is incorrect L

L-05 addAssets can DOS GovNFT minting L

L-06 Position.setMinter can be abused by owner and rug Trading users. L-05

L-07 remove deprecated functions NC

L-08 StableToken.setMinter can be abused by owner to steal vault underlying tokens from users L.05

N-01 Use a more recent version of Solidity NC

N-02 Function naming NC

N-03 Constants instead of magic numbers R

N-04 Line length NC

c4-sponsor commented 1 year ago

GainsGoblin marked the issue as sponsor confirmed

GalloDaSballo commented 1 year ago

5L 1R 4NC

c4-judge commented 1 year ago

GalloDaSballo marked the issue as grade-b