code-423n4 / 2022-12-tigris-findings

8 stars 4 forks source link

QA Report #541

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

GalloDaSballo commented 1 year ago

[L-01] BaseFundingRate can be over MaxFundingRate

L

[L-02] Unbounded values

L

[L-03] NO TRANSFER OWNERSHIP PATTERN

NC

[L-04] UNSPECIFIC COMPILER VERSION PRAGMA

NC

[L-05] Potential issue on synchronised data

R in lack of evidence

[L-06] USE SAFETRANSFER/SAFETRANSFERFROM CONSISTENTLY INSTEAD OF TRANSFER/TRANSFERFROM

OOS

[N-01] Not using named import

NC

[N-02] LINES ARE TOO LONG

NC

[N-03] USE A MORE RECENT VERSION OF SOLIDITY

NC

 [N-04] Inconsistent Private constant

NC

 [N-05] Make readable code, split lines for readability -> N-02

 [N-06] No emit for storage variable change set

NC

[N-08] Make space between aritmetic operator for code visibility

R

[N-09] Use uint256 consistently even though uint is same type

NC

[N-10] LARGE MULTIPLES OF TEN SHOULD USE SCIENTIFIC NOTATION

R

[N-11] USE BYTES.CONCAT()

NC

c4-sponsor commented 1 year ago

GainsGoblin marked the issue as sponsor confirmed

GalloDaSballo commented 1 year ago

2L 2R 9NC

c4-judge commented 1 year ago

GalloDaSballo marked the issue as grade-c