search

code-423n4 / 2022-12-tigris-findings

8 stars 4 forks source link

Transfering GovNFT does not update mapping userDebt #549

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

Lines of code

https://github.com/code-423n4/2022-12-tigris/blob/588c84b7bb354d20cbca6034544c4faa46e6a80e/contracts/GovNFT.sol#L86-L102

Vulnerability details

Impact

Because of not updating the mapping userDebt for receiver (userDebt[for]) on the transfer of GovNFT token, the receiver may be harmed, because of not getting collected fees.

Proof of Concept

Function _transfer(...) is not updated for userDebt[for], here.

Tools Used

Manual review.

Recommended Mitigation Steps

Consider updating value in userDebt[for] on transfer.

GalloDaSballo commented 1 year ago

Will flag but this may be a way to pass on debt to others (vulnerability)

TriHaz commented 1 year ago

Invalid, the receiver is not supposed to get the pending rewards with the NFT transfer.

c4-sponsor commented 1 year ago

TriHaz marked the issue as sponsor disputed

GalloDaSballo commented 1 year ago

With very little info avaiable, and the sponsor disputing, am closing for lack of proof.

Always add a coded POC to offer a stronger chance of withstanding scrutiny

c4-judge commented 1 year ago

GalloDaSballo marked the issue as unsatisfactory: Insufficient proof