QA Report

[code423n4]

See the markdown file with the details of this report here.

[GalloDaSballo]

block.timestamp used as time proxy

Disputed

Use of hardcoded amount of days

R

Return value not being checked

R

Variable shadows another variable

Disputing as technically the variable is _owner and owner is a function

Deprecated code should be removed from the code

NC in this case

Use of magic numbers is confusing and risky

R

Naming convention of constants

R

Different versions of pragma

NC

Inconsistent spacing in comments

NC

Maximum line length exceeded

NC

Large multiples of ten should use scientific notation (e.g. 1e6) rather than decimal literals (e.g. 1000000), for readability

R

Missing inheritance

NC, personally disagree as Inheritance is poorly handled in solidity

Bad order of code

NC

Naming convention of variables

Disputing as very minor / personal

[GalloDaSballo]

5R 5NC

[c4-sponsor]

GainsGoblin marked the issue as sponsor confirmed

[c4-judge]

GalloDaSballo marked the issue as grade-c