search

code-423n4 / 2022-12-tigris-findings

8 stars 4 forks source link

QA Report #597

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

GalloDaSballo commented 1 year ago

require and revert statements

NC

typo's

NC

Const variable naming convention

R

Event missing index

NC

Solidity styling conventions

NC

Public functions

R

No 0 address checks on contract constructors

L

Create Lock function

Disputed

Extend lock function

Disputed

Function commented out as deprecated

R

function can be marked as private or be removed

NC

No checks for ERC20

OOS

No checks on users balance

Tx will revert, I disagree with this being valid

Consider increasing or using a higher gas value

R

Unchecked interger underflow/overflow

L

2L 4R 5NC

c4-sponsor commented 1 year ago

GainsGoblin marked the issue as sponsor confirmed

c4-judge commented 1 year ago

GalloDaSballo marked the issue as grade-c