search

code-423n4 / 2022-12-tigris-findings

8 stars 4 forks source link

QA Report #605

Closed code423n4 closed 1 year ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

GalloDaSballo commented 1 year ago

1. EXPRESSIONS SHOULD USE IMMUTABLE INSTEAD OF CONSTANTS

Mostly invalid

2. DECLARED INTERNAL FUNCTION HAS NOT BEEN USED AND CAN BE REMOVED.

R

 3. USE NAMED IMPORTS INSTEAD OF PLAIN `IMPORT ‘FILE.SOL’

NC

 4. BE EXPLICIT WHEN DECLARING TYPES

NC

5. USE UPPERCASE LETTERS WHEN DECLARING CONSTANTS

R

6. Missing address(0) checks for _protocol

L

7. EVENT IS MISSING INDEXED FIELDS

Disputing per lack of detail

GalloDaSballo commented 1 year ago

1L 2R 2NC

c4-sponsor commented 1 year ago

GainsGoblin marked the issue as sponsor confirmed

c4-judge commented 1 year ago

GalloDaSballo marked the issue as grade-c