search

code-423n4 / 2022-12-tigris-findings

8 stars 4 forks source link

QA Report #658

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

GalloDaSballo commented 1 year ago

[L-01] NO UPPER LIMIT ON NUMBER OF REWARD ASSET TOKENS IN GovNFT CONTRACT

L

[L-02] super._safeMint FUNCTION CAN BE CALLED INSTEAD OF super._mint FUNCTION FOR MINTING GOVERNANCE NFTS

L

[L-03] super._safeTransfer FUNCTION CAN BE CALLED INSTEAD OF super._transfer FUNCTION FOR TRANSFERRING GOVERNANCE NFTS

L

[L-04] USDT IS NOT SUPPORTED FOR CALLING Trading._handleDeposit FUNCTION ON ETHEREUM MAINNET

Dup 198 / M-12

[L-05] MARGIN ASSET TOKENS WITH MORE THAN 18 DECIMALS ARE NOT SUPPORTED

Dup 533 / M-01

[L-06] UNSAFE decimals() CALL FOR MARGIN ASSET TOKENS THAT DO NOT IMPLEMENT decimals()

L

c4-sponsor commented 1 year ago

GainsGoblin marked the issue as sponsor confirmed

GalloDaSballo commented 1 year ago

4L

GalloDaSballo commented 1 year ago

2L from dups

6L

c4-judge commented 1 year ago

GalloDaSballo marked the issue as grade-b

GalloDaSballo commented 1 year ago

Despite the report "mathematically not making it", I chose to award it a B because it in aggregate is very valuable (6 Low Severity findings)