search

code-423n4 / 2022-12-tigris-findings

8 stars 4 forks source link

Gas Optimizations #663

Open code423n4 opened 1 year ago

code423n4 commented 1 year ago

See the markdown file with the details of this report here.

GalloDaSballo commented 1 year ago

[G-1] State variables and struct can be closely packed to save gas

 1st instance in the Trading.sol in the Fees struct

All are read at same time, so it will save reading 2 slots

4.2k

2nd

Unclear, skipping

3rd

2.1k

4th

2.1k

8400

c4-sponsor commented 1 year ago

GainsGoblin marked the issue as sponsor confirmed

c4-judge commented 1 year ago

GalloDaSballo marked the issue as grade-b

GalloDaSballo commented 1 year ago

Simple report, high impact, barely made it, good start!

GalloDaSballo commented 1 year ago

In contrast to other reports, I chose to award a B to this one despite it "mathematically falling short" because of the conciseness and value of each individual reports.

Going forward I recommend more wardens focus on High Impact Findings which will ultimately produce better reports for everyone