search

code-423n4 / 2022-12-tigris-findings

8 stars 4 forks source link

Upgraded Q -> M from #351 [1674418158719] #667

Closed c4-judge closed 1 year ago

c4-judge commented 1 year ago

Judge has assessed an item in Issue #351 as M risk. The relevant finding follows:

Stable Vault cannot accept tokens with more then 18 decimals because of this lines: https://github.com/code-423n4/2022-12-tigris/blob/588c84b7bb354d20cbca6034544c4faa46e6a80e/contracts/StableVault.sol#L49 https://github.com/code-423n4/2022-12-tigris/blob/588c84b7bb354d20cbca6034544c4faa46e6a80e/contracts/StableVault.sol#L67 Consider using different conversion formula. For example: amount * 1e18 / 10*token.decimals() for deposit and amount 10**token.decimals() / 1e18 for withdraw

c4-judge commented 1 year ago

GalloDaSballo marked the issue as duplicate of #533

c4-judge commented 1 year ago

GalloDaSballo marked the issue as satisfactory