search

code-423n4 / 2022-12-tigris-findings

8 stars 4 forks source link

Upgraded Q -> M from #445 [1674423223201] #675

Closed c4-judge closed 1 year ago

c4-judge commented 1 year ago

Judge has assessed an item in Issue #445 as M risk. The relevant finding follows:

[[5]] Function crossChain() in GovNFT should have limit for maximum tokens allowed to be transferred, because of gas limit in the dest chain. if a user transferred a lot of tokens because there was two loop inside each other in handling logic(one loop through NFT token ids and one loop through assets list so the execution is in order #NFTs * #Assets) so transaction can be revert in the destination chain. https://github.com/code-423n4/2022-12-tigris/blob/588c84b7bb354d20cbca6034544c4faa46e6a80e/contracts/GovNFT.sol#L124-L165

c4-judge commented 1 year ago

GalloDaSballo marked the issue as duplicate of #334

c4-judge commented 1 year ago

GalloDaSballo marked the issue as satisfactory